fix: explicitly specify jsBundleAssetPath to fix loading of JS bundle in release mode on RN 0.81 & 0.82#154
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
… in release mode on RN 0.81 & 0.82 (fix in RN not backported - see react/react-native#53546)
artus9033
force-pushed
the
fix/default-bundle-filename
branch
from
a55b399 to
ff9b047
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RN 0.81 & 0.82 have a bugged default value of the
jsBundleAssetPathargument, which controls the filename to be loaded fromasset://. By default, it isindex, which is correct for Metro (dev mode)jsMainModulePath, but incorrect for asset bundle - it should beindex.android.bundle.The fix is present in RN upstream and included in 0.83 RC (react/react-native#53546), but has not been backported.
This PR passes the correct default value explicitly and also allows users to pass a custom value for this argument via the options HashMap.
Test plan
Run an app in release variant using an exported AAR & verify that the JS bundle is loaded and executed correctly.
Note
Explicitly sets
jsBundleAssetPath(defaultindex.android.bundle) in React host initialization and documents the option in Java/Kotlin guides.ReactNativeBrownfield.initialize(application, options, ...)to passjsBundleAssetPathtogetDefaultReactHost, defaulting to"index.android.bundle"and allowing override viaoptions["bundleAssetPath"].mainModuleNameapplies when loading from Metro.jsBundleAssetPathoption description for Java/Kotlin (docs/JAVA.md,docs/KOTLIN.md).Written by Cursor Bugbot for commit ff9b047. This will update automatically on new commits. Configure here.